executablebooks / sphinx-book-theme

A clean book theme for scientific explanations and documentation with Sphinx
https://sphinx-book-theme.readthedocs.io
BSD 3-Clause "New" or "Revised" License
429 stars 198 forks source link

BUG: fix for pydata-sphinx-theme>=0.13.3 #714

Closed jakevdp closed 1 year ago

jakevdp commented 1 year ago

Fixes #711 by pinning to pydata-sphinx-theme>=0.13.3 and using the new pydata_sphinx_theme.utils submodule

welcome[bot] commented 1 year ago

Thanks for submitting your first pull request! You are awesome! :hugs:
If you haven't done so already, check out EBP's Code of Conduct and our Contributing Guide, as this will greatly help the review process.
Welcome to the EBP community! :tada:

mmcky commented 1 year ago

thanks @jakevdp for this PR.

@AakashGfude this looks good to me but not overly familiar with the code base. Could you please review this and organise a new release? Thanks.

AakashGfude commented 1 year ago

Thanks @jakevdp , this is awesome. I noticed a few UI issues which I have listed here: https://github.com/executablebooks/sphinx-book-theme/issues/715 . I will merge this, fix them, and cut a release.

welcome[bot] commented 1 year ago

Congrats on your first merged pull request in this project! :tada: congrats
Thank you for contributing, we are very proud of you! :heart:

Saksham-13 commented 1 year ago

Thanks @jakevdp , this is awesome. I noticed a few UI issues which I have listed here: #715 . I will merge this, fix them, and cut a release.

hey, by when will this be released?

mauritsvanrees commented 1 year ago

I confirm that version 1.0.1 fixes this. Thanks!

jakevdp commented 1 year ago

Thanks all!