welcome[bot]
commented
1 year ago Thanks for opening your first issue here! Engagement like this is essential for open source projects! :hugs:
If you haven't done so already, check out EBP's Code of Conduct. Also, please try to follow the issue template as it helps other community members to contribute more effectively.
If your issue is a feature request, others may react to it, to raise its prominence (see Feature Voting).
Welcome to the EBP community! :tada:
Hi all,
First, thanks for the amazing work on this theme! :slightly_smiling_face:
Just noticed a very minor issue while hovering over the Binder launcher, there is a space missing in the tooltip, it shows as:
Launch onBinderLooks like this needs to be corrected for all launcher types: https://github.com/executablebooks/sphinx-book-theme/blob/c2664ddfbe2c3fcfaa819a57835f00ca58346cb9/src/sphinx_book_theme/header_buttons/launch.py#L136 https://github.com/executablebooks/sphinx-book-theme/blob/c2664ddfbe2c3fcfaa819a57835f00ca58346cb9/src/sphinx_book_theme/header_buttons/launch.py#L154 https://github.com/executablebooks/sphinx-book-theme/blob/c2664ddfbe2c3fcfaa819a57835f00ca58346cb9/src/sphinx_book_theme/header_buttons/launch.py#L169 https://github.com/executablebooks/sphinx-book-theme/blob/c2664ddfbe2c3fcfaa819a57835f00ca58346cb9/src/sphinx_book_theme/header_buttons/launch.py#L185
Or maybe I don't fully get the behaviour of
sphinx.locale.get_translation? Happy to open a PR if that saves time.On another topic: Any update/plan to work on https://github.com/executablebooks/sphinx-book-theme/issues/282? I'm also very interested in that feature, could potentially contribute if nothing is ongoing already.