search

executablebooks / sphinx-book-theme

A clean book theme for scientific explanations and documentation with Sphinx
https://sphinx-book-theme.readthedocs.io
BSD 3-Clause "New" or "Revised" License
429 stars 198 forks source link

Minor bug: Navbar doesn't darken when loading #734

Open jeffchiou opened 1 year ago

jeffchiou commented 1 year ago

Describe the bug

When I load or reload the MyST Live Preview page, I expected the page to darken while the live preview was loading. But instead the navbar stays lit:

book-theme-navbar-bug

problem This is a minor aesthetic problem.

Reproduce the bug

  1. Go to the MyST Live Preview page and watch it load.
  2. Can also turn on network throttling to see the effect for longer.

List your environment

This happens in Chrome 113.0.5672.93 and Firefox 113.0.1, with and without plugins, on Ubuntu and Windows, and in dark and light mode (although it is more noticeable in light mode).

welcome[bot] commented 1 year ago

Thanks for opening your first issue here! Engagement like this is essential for open source projects! :hugs:
If you haven't done so already, check out EBP's Code of Conduct. Also, please try to follow the issue template as it helps other community members to contribute more effectively.
If your issue is a feature request, others may react to it, to raise its prominence (see Feature Voting).
Welcome to the EBP community! :tada: