FIX: set bd-docs-nav as a class attribute instead of an id to restore compat with pydata-sphinx-theme JS

executablebooks / sphinx-book-theme

A clean book theme for scientific explanations and documentation with Sphinx

https://sphinx-book-theme.readthedocs.io

BSD 3-Clause "New" or "Revised" License

433 stars 197 forks source link

FIX: set bd-docs-nav as a class attribute instead of an id to restore compat with pydata-sphinx-theme JS #754

Closed ogrisel closed 12 months ago

ogrisel commented 1 year ago

This is a partial fix for #541.

It makes the scrollToActive function from pydata-sphinx-theme.js work as expected on jupyter-book rendered HTML.

However, this function does not save the collapsed state of other sections which make the "scroll to saved location" a bit weird/broken at times.

Still, it's already much better than the current state.

welcome[bot] commented 1 year ago

Thanks for submitting your first pull request! You are awesome! :hugs:
If you haven't done so already, check out EBP's Code of Conduct and our Contributing Guide, as this will greatly help the review process.
Welcome to the EBP community! :tada:

welcome[bot] commented 12 months ago

Congrats on your first merged pull request in this project! :tada:
Thank you for contributing, we are very proud of you! :heart: