search

executablebooks / sphinx-book-theme

A clean book theme for scientific explanations and documentation with Sphinx
https://sphinx-book-theme.readthedocs.io
BSD 3-Clause "New" or "Revised" License
439 stars 201 forks source link

DOCS: require compatible docutils #800

Closed agoose77 closed 9 months ago

agoose77 commented 11 months ago

The widespread problem with docutils 0.17 and 0.18 also affects our docs generation. As our optional docs extra is intended for internal use only, we can describe the compatibility safely in pyproject.toml rather than worrying about backsolving.

Fixes #799

choldgraf commented 11 months ago

Looks like we're using a deprecated function (add_javascript I believe is now add_js_file).

EDIT: Ah shoot it is in sphinx-tabs so we gotta make the fix there and make a release.

EDIT EDIT: Looks like the fix is already in there and released here: https://github.com/executablebooks/sphinx-tabs/releases/tag/v3.4.4 but for some reason this is getting downgraded in the build:

CleanShot 2023-12-20 at 11 56 49@2x

Also that website preview is pretty glorious haha

agoose77 commented 11 months ago

The issue here is the widespread docutils div bug, and we're seeing it because sphinx-tabs doesn't yet support sphinx 7 (thus everything is downgraded). As a result, the fix is really in Sphinx-tabs (I have an open pr there)!

choldgraf commented 11 months ago

Ah yes the docutils gift that keeps on giving