search

executablebooks / sphinx-book-theme

A clean book theme for scientific explanations and documentation with Sphinx
https://sphinx-book-theme.readthedocs.io
BSD 3-Clause "New" or "Revised" License
409 stars 196 forks source link

FIX: `.bd-sizebar-secondary` and `.secondary-toggle` breakpoint #809

Closed sinsong closed 3 weeks ago

sinsong commented 5 months ago

My friend find that .bd-sidebar-secondary collapse before .secondary-toggle appear. Which means, viewport width between 1200px (xl breakpoint) and 992px (lg breakpoint), both sidebar and toggle button disappear.

I find that a rule come from pydata-sphinx-theme interact with .bd-sidebar-secondary cause collapse less that 1200px (exactly at 1199.98px). With the breakpoint xl.

So this PR is for synchronize .secondary-toogle button with .bd-sidebar-secondary collapse through align breakpoint to xl.

welcome[bot] commented 5 months ago

Thanks for submitting your first pull request! You are awesome! :hugs:
If you haven't done so already, check out EBP's Code of Conduct and our Contributing Guide, as this will greatly help the review process.
Welcome to the EBP community! :tada:

agoose77 commented 3 weeks ago

This matches my read of the upstream code, which sets $breakpoint-sidebar-secondary: xl;: https://github.com/pydata/pydata-sphinx-theme/blob/05fd48a8159d6d4046a06df6688efae0dacf34eb/src/pydata_sphinx_theme/assets/styles/variables/_layout.scss#L21-L22