FIX: fixes to the dropdown buttons

executablebooks / sphinx-book-theme

A clean book theme for scientific explanations and documentation with Sphinx

https://sphinx-book-theme.readthedocs.io

BSD 3-Clause "New" or "Revised" License

409 stars 196 forks source link

FIX: fixes to the dropdown buttons #831

Closed afeld closed 3 months ago

afeld commented 3 months ago

This pull request includes a handful of improvements around the drop-down/launch buttons:

Improves the interactivity of the drop-down buttons: Version 1.0.0 introduced a gap between the hover area and the drop-down. When the mouse would move from the former to the latter (especially if slowly), the drop-down would disappear. You can see this behavior on the live site. cc @choldgraf since you did work in this area.
Adds alt text to the launch button logos
Adds a space between "Launch on" and the tool name - fixes https://github.com/executablebooks/sphinx-book-theme/issues/722 cc @rhugonnet

Screenshot showing "Launch on Colab"

welcome[bot] commented 3 months ago

Thanks for submitting your first pull request! You are awesome! :hugs:
If you haven't done so already, check out EBP's Code of Conduct and our Contributing Guide, as this will greatly help the review process.
Welcome to the EBP community! :tada:

agoose77 commented 3 months ago

@choldgraf LGTM, but do cast your eye over the SBT dropdowns for "Launch on"; I didn't author this originally, so I'm not familiar with whether this is a regression or a long-standing bug.

afeld commented 3 months ago

Looks like it was introduced with the translation in https://github.com/executablebooks/sphinx-book-theme/commit/1656b772f78153e18bebde637c27482e30d4365c#diff-c18ac40355c51c6c6566efc355dfa5e7f002859040252df71ebc2d3a01da96bcL115.

welcome[bot] commented 3 months ago

Congrats on your first merged pull request in this project! :tada:
Thank you for contributing, we are very proud of you! :heart: