search

executablebooks / sphinx-design

A sphinx extension for designing beautiful, screen-size responsive web components.
https://sphinx-design.readthedocs.io/en/furo-theme/
MIT License
187 stars 57 forks source link

Support latest Octicon icons #180

Closed MarcSkovMadsen closed 1 month ago

MarcSkovMadsen commented 5 months ago

Context

I am trying to do docs contributions to HoloViz Panel. I notice that something does not work when I use specific Octicon icons in the cards.

In https://github.com/holoviz/panel/issues/6318 I request Panel to support these icons. But I'm told its really Sphinx-Design that do not support them. Sphinx-Design only supports the octicon-icons listed in https://sphinx-design.readthedocs.io/en/latest/badges_buttons.html#octicon-icons

Proposal

Support all Octicon Icons that can be found at https://primer.style/foundations/icons

Not Working

image

welcome[bot] commented 5 months ago

Thanks for opening your first issue here! Engagement like this is essential for open source projects! :hugs:
If you haven't done so already, check out EBP's Code of Conduct. Also, please try to follow the issue template as it helps other community members to contribute more effectively.
If your issue is a feature request, others may react to it, to raise its prominence (see Feature Voting).
Welcome to the EBP community! :tada:

chrisjsewell commented 1 month ago

This should be closed by #171, but feel free to re-open if not

MarcSkovMadsen commented 1 month ago

Thx