search

executablebooks / sphinx-exercise

A Sphinx extension for producing exercise and solution directives.
https://ebp-sphinx-exercise.readthedocs.io
MIT License
19 stars 7 forks source link

πŸ‘Œ IMPROVE: Support numref placeholders #5

Closed najuzilu closed 4 years ago

najuzilu commented 4 years ago

This PR allows {number} and {name} to work if referenced in the same role while %s only works if referenced by itself. This seems to be the behavior of the general numref role. For instance, {number} {name} %s will display number and name while "%s" won't work. The same is true for {number} %s and {name} %s. However, if "%s" is introduced by itself, it will display the number of the exercise directive.

codecov-io commented 4 years ago

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@63524aa). Click here to learn what that means. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master       #5   +/-   ##
=========================================
  Coverage          ?   96.80%           
=========================================
  Files             ?        3           
  Lines             ?      344           
  Branches          ?        0           
=========================================
  Hits              ?      333           
  Misses            ?       11           
  Partials          ?        0
Flag Coverage Ξ”
#pytests 96.80% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more Ξ” = absolute <relative> (impact), ΓΈ = not affected, ? = missing data Powered by Codecov. Last update 63524aa...efc37bf. Read the comment docs.