lukasbindreiter commented 2 years ago

As far as I can tell no click features are used that prevent an upgrade to v8 of click.

See https://github.com/executablebooks/jupyter-book/issues/1590 for more info as to why this is necessary.

welcome[bot] commented 2 years ago

Thanks for submitting your first pull request! You are awesome! :hugs:
If you haven't done so already, check out EBP's Code of Conduct and our Contributing Guide, as this will greatly help the review process.
Welcome to the EBP community! :tada:

codecov[bot] commented 2 years ago

Codecov Report

Merging #69 (24197bd) into main (3bb41e6) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##             main      #69   +/-   ##
=======================================
  Coverage   90.75%   90.75%           
=======================================
  Files           6        6           
  Lines         660      660           
=======================================
  Hits          599      599           
  Misses         61       61

Flag	Coverage Δ
pytests	`90.75% <ø> (ø)`

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 3bb41e6...24197bd. Read the comment docs.

welcome[bot] commented 2 years ago

Congrats on your first merged pull request in this project! :tada:
Thank you for contributing, we are very proud of you! :heart:

executablebooks / sphinx-external-toc

⬆️ UPGRADE: allow click v8 #69

Codecov Report