search

executablebooks / sphinx-jupyter-book-theme

An experimental Sphinx theme for Jupyter Book
BSD 3-Clause "New" or "Revised" License
2 stars 3 forks source link

Question about dependencies #4

Open akhmerov opened 4 years ago

akhmerov commented 4 years ago

How does this theme depend on IPython, nbsphinx, and ipywidgets? These don't appear to be used anywhere in the repo aside of setup.py.

rossbar commented 4 years ago

Re: IPython - it is likely not a dependency of the theme itself, but is nice for testing code blocks as it provides the pygments syntax highlighter (which suppresses a slew of sphinx errors).

I wouldn't be surprised if the other dependencies are there for similar reasons. Breaking them out into an extras_require entry in the setup.py would be good.

akhmerov commented 4 years ago

Thanks for the clarification. If it's only for testing, there's also tests_require.

choldgraf commented 4 years ago

Yep - that's definitely correct. More generally, this repository is very much in an "this is super young and there has been almost effort made into professionalizing things yet" phase :-)

I'd be +1 on any changes that improve this so it's less confusing or bulky.