Closed jfbu closed 2 years ago
Thanks for submitting your first pull request! You are awesome! :hugs:
If you haven't done so already, check out EBP's Code of Conduct and our Contributing Guide, as this will greatly help the review process.
Welcome to the EBP community! :tada:
In second commit I removed \makeatletter/\makeatother
as @
is not used.
But anyhow as this is a .cls
file so a priori if used normally (i.e. not directly via \input
but via \documentclass
) then the @
needed no \makeatletter/\makeatother
wrapper to start with anyhow.
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 93.21%. Comparing base (
6785357
) to head (90d4bd5
). Report is 9 commits behind head on master.
Thanks @jfbu, this code looks good to me.
Congrats on your first merged pull request in this project! :tada:
Thank you for contributing, we are very proud of you! :heart:
This avoids using private Sphinx macro \spx@verbatimfcolorbox which got renamed at Sphinx 5.1.0 and whose definition would thus remain without effect.
Fixes: #101