executablebooks / sphinx-jupyterbook-latex

Supporting LaTeX infrastructure for Jupyter Book
https://sphinx-jupyterbook-latex.readthedocs.io
BSD 3-Clause "New" or "Revised" License
29 stars 13 forks source link

FIX: set colours for Verbatim without using private Sphinx macros #102

Closed jfbu closed 2 years ago

jfbu commented 2 years ago

This avoids using private Sphinx macro \spx@verbatimfcolorbox which got renamed at Sphinx 5.1.0 and whose definition would thus remain without effect.

Fixes: #101

welcome[bot] commented 2 years ago

Thanks for submitting your first pull request! You are awesome! :hugs:
If you haven't done so already, check out EBP's Code of Conduct and our Contributing Guide, as this will greatly help the review process.
Welcome to the EBP community! :tada:

jfbu commented 2 years ago

In second commit I removed \makeatletter/\makeatother as @ is not used.

But anyhow as this is a .cls file so a priori if used normally (i.e. not directly via \input but via \documentclass) then the @ needed no \makeatletter/\makeatother wrapper to start with anyhow.

codecov[bot] commented 2 years ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 93.21%. Comparing base (6785357) to head (90d4bd5). Report is 9 commits behind head on master.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/executablebooks/sphinx-jupyterbook-latex/pull/102/graphs/tree.svg?width=650&height=150&src=pr&token=NLWYF1WJAD&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=executablebooks)](https://app.codecov.io/gh/executablebooks/sphinx-jupyterbook-latex/pull/102?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=executablebooks) ```diff @@ Coverage Diff @@ ## master #102 +/- ## ======================================= Coverage 93.21% 93.21% ======================================= Files 4 4 Lines 398 398 ======================================= Hits 371 371 Misses 27 27 ``` | [Flag](https://app.codecov.io/gh/executablebooks/sphinx-jupyterbook-latex/pull/102/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=executablebooks) | Coverage Δ | | |---|---|---| | [pytests](https://app.codecov.io/gh/executablebooks/sphinx-jupyterbook-latex/pull/102/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=executablebooks) | `93.21% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=executablebooks#carryforward-flags-in-the-pull-request-comment) to find out more.
AakashGfude commented 2 years ago

Thanks @jfbu, this code looks good to me.

welcome[bot] commented 2 years ago

Congrats on your first merged pull request in this project! :tada: congrats
Thank you for contributing, we are very proud of you! :heart: