Closed AakashGfude closed 2 years ago
Attention: Patch coverage is 92.30769%
with 4 lines
in your changes missing coverage. Please review.
Project coverage is 93.35%. Comparing base (
e46854e
) to head (f7f8c72
). Report is 15 commits behind head on master.
Files with missing lines | Patch % | Lines |
---|---|---|
sphinx_jupyterbook_latex/transforms.py | 92.15% | 4 Missing :warning: |
@mmcky you know what is the best way to test different package versions in our test suite? The coverage is failing because we are testing one version of mystnb
@mmcky you know what is the best way to test different package versions in our test suite? The coverage is failing because we are testing one version of mystnb
I guess it would be to test against a matrix
if you want to test against older version of myst_nb. The jupyter-book
package tests against different version of sphinx in this example
aah cool. That's a good way to do it.
@AakashGfude how's this going. Let me know if you need any input.
@mmcky think this is ready to go.
thanks @AakashGfude this is looking great.
My last comment is it would be great to update the solution
xml
files to includemystnb
to be clear what the>14
belongs to such astests/test_transforms/test_hide_output_>14.resolved.xml
to
tests/test_transforms/test_hide_output_mystnb>14.resolved.xml
Will do @mmcky.
Also using 'findall' instead of traverse(if available as an attribute of the node) as recommended by docutils 0.18
fixes https://github.com/executablebooks/sphinx-jupyterbook-latex/issues/103