👌 IMPROVE: Accomodating mystnb 0.17, moved myst_nb to install_requires

[AakashGfude]

• [x] Changes necessary for myst-nb 0.17. fixes https://github.com/executablebooks/sphinx-jupyterbook-latex/issues/110
• [x] Have moved myst_nb to install_requires. @mmcky should this be done or we update the doc to have pip install sphinx-jupyterbook-latex[myst] instead.

[codecov[bot]]

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 93.35%. Comparing base (ddff626) to head (7b6f668). Report is 13 commits behind head on master.

Additional details and impacted files

[](https://app.codecov.io/gh/executablebooks/sphinx-jupyterbook-latex/pull/109?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=executablebooks) ```diff @@ Coverage Diff @@ ## master #109 +/- ## ======================================= Coverage 93.35% 93.35% ======================================= Files 4 4 Lines 391 391 ======================================= Hits 365 365 Misses 26 26 ``` | [Flag](https://app.codecov.io/gh/executablebooks/sphinx-jupyterbook-latex/pull/109/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=executablebooks) | Coverage Δ | | |---|---|---| | [pytests](https://app.codecov.io/gh/executablebooks/sphinx-jupyterbook-latex/pull/109/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=executablebooks) | `93.35% <100.00%> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=executablebooks#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files](https://app.codecov.io/gh/executablebooks/sphinx-jupyterbook-latex/pull/109?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=executablebooks) | Coverage Δ | | |---|---|---| | [sphinx\_jupyterbook\_latex/transforms.py](https://app.codecov.io/gh/executablebooks/sphinx-jupyterbook-latex/pull/109?src=pr&el=tree&filepath=sphinx_jupyterbook_latex%2Ftransforms.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=executablebooks#diff-c3BoaW54X2p1cHl0ZXJib29rX2xhdGV4L3RyYW5zZm9ybXMucHk=) | `92.77% <100.00%> (ø)` | |

[mmcky]

• [ ] we should also update the test matrix to python=3.9.

[chrisjsewell]

Guys this was specifically moved out of the requirements in #55, so I'm really not sure why you are adding back in

[AakashGfude]

@chrisjsewell yes I did see that. But we have imported myst_nb in transforms.py, like https://github.com/executablebooks/sphinx-jupyterbook-latex/blob/master/sphinx_jupyterbook_latex/transforms.py#L486. Or we should not run those transforms probably if myst_nb is not installed?

Sorry about that revert comment, it was by mistake

[chrisjsewell]

It was changed due to circular dependency issues in jupyter-book. It's ok if this is not an issue anymore, but yeh just have a check.

[mmcky]

@AakashGfude this will lock us into ensuring releases of sphinx-jupyterbook-latex and jupyter-book are synchronised to avoid these things. Perhaps it best to:

1. check if myst-nb is installed and if so treat the Cells (as per the PR)
2. drop back to a default behaviour if extension is used without myst-nb