executablebooks / sphinx-jupyterbook-latex

Supporting LaTeX infrastructure for Jupyter Book
https://sphinx-jupyterbook-latex.readthedocs.io
BSD 3-Clause "New" or "Revised" License
29 stars 13 forks source link

MAINT: bump upper sphinx version limit to 5.1 #114

Closed michaelosthege closed 2 years ago

michaelosthege commented 2 years ago

Since 0.5.0 this package should be compatible with Sphinx 5, or more precisely with sphinx<5.1 as because of #101.

As explained in https://github.com/conda-forge/sphinx-jupyterbook-latex-feedstock/pull/11#issue-1435774378 I'm using this successfully with Sphinx 5.0.1, but conda/mamba currently don't resolve such environments because sphinx-jupyterbook-latex still specifies sphinx<5.

welcome[bot] commented 2 years ago

Thanks for submitting your first pull request! You are awesome! :hugs:
If you haven't done so already, check out EBP's Code of Conduct and our Contributing Guide, as this will greatly help the review process.
Welcome to the EBP community! :tada:

codecov[bot] commented 2 years ago

Codecov Report

Merging #114 (f91555d) into master (d841b28) will not change coverage. The diff coverage is n/a.

Additional details and impacted files [![Impacted file tree graph](https://codecov.io/gh/executablebooks/sphinx-jupyterbook-latex/pull/114/graphs/tree.svg?width=650&height=150&src=pr&token=NLWYF1WJAD&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=executablebooks)](https://codecov.io/gh/executablebooks/sphinx-jupyterbook-latex/pull/114?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=executablebooks) ```diff @@ Coverage Diff @@ ## master #114 +/- ## ======================================= Coverage 93.21% 93.21% ======================================= Files 4 4 Lines 398 398 ======================================= Hits 371 371 Misses 27 27 ``` | Flag | Coverage Δ | | |---|---|---| | pytests | `93.21% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=executablebooks#carryforward-flags-in-the-pull-request-comment) to find out more.
welcome[bot] commented 2 years ago

Congrats on your first merged pull request in this project! :tada: congrats
Thank you for contributing, we are very proud of you! :heart: