Closed pradyunsg closed 3 years ago
Thanks for submitting your first pull request! You are awesome! :hugs:
If you haven't done so already, check out EBP's Code of Conduct and our Contributing Guide, as this will greatly help the review process.
Welcome to the EBP community! :tada:
Cheeers, but you didn't install pre-commit did you 😉
Well, I made the PR from the GitHub UI. 🙃
I've made a comment in #32 regarding the use of pre-commit for compiling the SCSS. :)
Well, I made the PR from the GitHub UI
Thats surely always an issue for pre-commit check though, your always likely to break a pre-commit from the GitHub UI. I would always discourage to make changes purely via the GitHub UI.
our always likely to break a pre-commit from the GitHub UI
Well, not once http://pre-commit.ci/ is alive and installed. :P
Ok ta, this makes the labels fairly big, I'll merge this for now, but actually will then look to just make the label size configurable (like the colors)
Congrats on your first merged pull request in this project! :tada:
Thank you for contributing, we are very proud of you! :heart:
this makes the labels fairly big,
Oooo. Interesting! Looking at the font-size rule, that seems to be the expected behaviour?
The borrowed/adapted code does not set the dimensions correctly, since this extension does not directly control the value of 1rem, and does not override it to be 20px like mkdocs-material does.
https://github.com/squidfunk/mkdocs-material/blob/d7c28f93195352541e444ba5f54a377ca24002fa/src/assets/stylesheets/main/layout/_base.scss#L35-L61
This PR sets 1rem to 16px (the default) which should result in expected behavior on basically all the Sphinx themes. :)
One of the symptoms is the thinner-than-expected underline and overline on the tabbed content.