executablebooks / sphinx-panels

A sphinx extension for creating panels in a grid layout
https://sphinx-panels.readthedocs.io
MIT License
83 stars 20 forks source link

CSS conflicts with Sphinx-Tabs #51

Open Daltz333 opened 3 years ago

Daltz333 commented 3 years ago

Describe the bug

The extension seems to expand the maximum width of sphinx-tabs to the full width of the page.

image

See https://frc-docs--901.org.readthedocs.build/en/901/docs/software/advanced-controls/filters/median-filter.html#using-a-medianfilter

To Reproduce

Offending PR: https://github.com/wpilibsuite/frc-docs/pull/901

Install Sphinx-Tabs and Sphinx-Panels with Sphinx 3.1.2 and Python 3

Expected behavior

The original sphinx-tabs to retain it's style. Ideally we'd like to use both sphinx-tabs and sphinx-panels (we prefer the design of sphinx-tabs over sphinx-panels .. tabbed:: as well as we make extensive use of group-tabs)

https://frc-docs--901.org.readthedocs.build/en/901/ image

Environment

Additional context

https://github.com/wpilibsuite/frc-docs

welcome[bot] commented 3 years ago

Thanks for opening your first issue here! Engagement like this is essential for open source projects! :hugs:
If you haven't done so already, check out EBP's Code of Conduct. Also, please try to follow the issue template as it helps other community members to contribute more effectively.
If your issue is a feature request, others may react to it, to raise its prominence (see Feature Voting).
Welcome to the EBP community! :tada:

Daltz333 commented 3 years ago

Additionally research shows that bootstrap is missing up with some margins and padding. I've managed to get it looking somewhat right by doing the below modifications:

Removing all of the following style fixes it image

Which gives the original output looking like the following image

chrisjsewell commented 3 years ago

Hey @Daltz333 yep see https://github.com/executablebooks/sphinx-tabs/issues/90. This is a fix we need to make on the sphinx-tabs end. Having said that I might just add groups here

Daltz333 commented 3 years ago

If tab groups do get added here, we may consider switching after tweaking some of the CSS a bit. Especially as this project seems much more maintained.