search

executablebooks / sphinx-panels

A sphinx extension for creating panels in a grid layout
https://sphinx-panels.readthedocs.io
MIT License
83 stars 20 forks source link

🔧 MAINT: adding check for bootstrap themes #54

Closed choldgraf closed 3 years ago

choldgraf commented 3 years ago

This adds a check for the theme name, and if it is one of the "bootstrap" themes that we know of, it automatically does not add bootstrap CSS through sphinx-panels.

I wasn't sure how to test this, so for the time being I've disabled panels_add_bootstrap_css for the two bootstrap themes that we demo, and I figure at least we can confirm that bootstrap is behaving as-expected on those two demos to make sure this is working. WDYT?

choldgraf commented 3 years ago

closing this, as sphinx-design no longer requires this configuration, I believe: https://sphinx-design.readthedocs.io/en/latest/get_started.html