search

executablebooks / sphinx-panels

A sphinx extension for creating panels in a grid layout
https://sphinx-panels.readthedocs.io
MIT License
83 stars 20 forks source link

No i18n support for link-button directive #68

Open jpmckinney opened 3 years ago

jpmckinney commented 3 years ago

The :text: option is not passed through gettext. It is not extracted by Sphinx's gettext builder.

I think the "easy" solution is to put the text in the body of the directive, like all other directives.

I guess this would require a major/minor version change, unless you support both :text: options and directive bodies at once.

welcome[bot] commented 3 years ago

Thanks for opening your first issue here! Engagement like this is essential for open source projects! :hugs:
If you haven't done so already, check out EBP's Code of Conduct. Also, please try to follow the issue template as it helps other community members to contribute more effectively.
If your issue is a feature request, others may react to it, to raise its prominence (see Feature Voting).
Welcome to the EBP community! :tada:

chrisjsewell commented 3 years ago

Heya, as mentioned in #67, this package is essentially being deprecated for sphinx-design, and that is indeed exactly how it works there: https://sphinx-design.readthedocs.io/en/latest/badges_buttons.html#buttons

jpmckinney commented 3 years ago

Awesome!