executablebooks / sphinx-proof

A Sphinx extension for producing proof, theorem, lemma, definition, remark, conjecture, corollary and algorithm directives.
https://sphinx-proof.readthedocs.io/en/latest/
MIT License
32 stars 17 forks source link

Support for Exercises directive & Added Chinese translation (zh_CN) #88

Closed 11Haoyu closed 2 years ago

11Haoyu commented 2 years ago

Co-authored-by: Ming Yang vivym@live.com

mmcky commented 2 years ago

thanks for this PR @11Haoyu -- I will review soon and see if we can get this merged.

codecov-commenter commented 2 years ago

Codecov Report

Base: 96.13% // Head: 96.17% // Increases project coverage by +0.04% :tada:

Coverage data is based on head (f43d4b9) compared to base (d37495f). Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #88 +/- ## ========================================== + Coverage 96.13% 96.17% +0.04% ========================================== Files 6 6 Lines 362 366 +4 ========================================== + Hits 348 352 +4 Misses 14 14 ``` | Flag | Coverage Δ | | |---|---|---| | pytests | `96.17% <100.00%> (+0.04%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=executablebooks#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/executablebooks/sphinx-proof/pull/88?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=executablebooks) | Coverage Δ | | |---|---|---| | [sphinx\_proof/nodes.py](https://codecov.io/gh/executablebooks/sphinx-proof/pull/88/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=executablebooks#diff-c3BoaW54X3Byb29mL25vZGVzLnB5) | `93.63% <100.00%> (+0.11%)` | :arrow_up: | | [sphinx\_proof/proof\_type.py](https://codecov.io/gh/executablebooks/sphinx-proof/pull/88/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=executablebooks#diff-c3BoaW54X3Byb29mL3Byb29mX3R5cGUucHk=) | `100.00% <100.00%> (ø)` | | | [sphinx\_proof/translations/\_convert.py](https://codecov.io/gh/executablebooks/sphinx-proof/pull/88/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=executablebooks#diff-c3BoaW54X3Byb29mL3RyYW5zbGF0aW9ucy9fY29udmVydC5weQ==) | `93.33% <100.00%> (ø)` | | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=executablebooks). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=executablebooks)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

mmcky commented 2 years ago

@11Haoyu there are just a few pre-commit issues re: styling etc.

Running pre-commit will solve these for you locally

https://pre-commit.com