executablebooks / sphinx-tabs

Tabbed views for Sphinx
https://sphinx-tabs.readthedocs.io
MIT License
264 stars 68 forks source link

Fix parsing for unsupported builders, including rinohtype (for pdf) #103

Closed foster999 closed 3 years ago

foster999 commented 3 years ago

Now uses base docutils classes when builder is unsupported, rather than custom sphinx-tabs nodes.

Added test for successful building with rinohtype. This includes regression testing of the XML, but not the output pdf. Turns out pdf's are quite awkward to diff!

Fixes #99

codecov[bot] commented 3 years ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 97.10%. Comparing base (f16c3a0) to head (918bb16). Report is 53 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #103 +/- ## ========================================== + Coverage 94.08% 97.10% +3.01% ========================================== Files 1 1 Lines 203 207 +4 ========================================== + Hits 191 201 +10 + Misses 12 6 -6 ``` | [Flag](https://app.codecov.io/gh/executablebooks/sphinx-tabs/pull/103/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=executablebooks) | Coverage Δ | | |---|---|---| | [pytests](https://app.codecov.io/gh/executablebooks/sphinx-tabs/pull/103/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=executablebooks) | `97.10% <100.00%> (+3.01%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=executablebooks#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Daltz333 commented 3 years ago

I'll review and test with my groups documentation in a few hours

foster999 commented 3 years ago

Thanks, that would be really useful as the test example is quite minimal 👍🏻

Daltz333 commented 3 years ago

Seems to build and look fine on my teams PDF https://github.com/wpilibsuite/frc-docs/suites/1985343336/artifacts/39545658

foster999 commented 3 years ago

Great, thanks for giving it a try