executablebooks / sphinx-tabs

Tabbed views for Sphinx
https://sphinx-tabs.readthedocs.io
MIT License
264 stars 68 forks source link

🧪 TESTS: Skip failing rinohtype tests #124

Closed foster999 closed 3 years ago

foster999 commented 3 years ago

I can't reproduce or identify the source of this test's failure below Python v3.8.

Skipping these tests on versions below 3.8 will allow us to release until #123 is resolved.

codecov[bot] commented 3 years ago

Codecov Report

Merging #124 (bedb905) into master (69f31ff) will decrease coverage by 4.61%. The diff coverage is 83.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #124      +/-   ##
==========================================
- Coverage   97.16%   92.55%   -4.62%     
==========================================
  Files           2        2              
  Lines         212      215       +3     
==========================================
- Hits          206      199       -7     
- Misses          6       16      +10     
Flag Coverage Δ
pytests 92.55% <83.33%> (-4.62%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
sphinx_tabs/tabs.py 92.48% <83.33%> (-4.66%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 5564197...bedb905. Read the comment docs.

foster999 commented 3 years ago

@Daltz333, would you be happy for this to go in so that #117 can be released?

I'm happy to wait until this can be fixed properly, but not sure when I'll have a chance to take a deeper look