executablebooks / sphinx-tabs

Tabbed views for Sphinx
https://sphinx-tabs.readthedocs.io
MIT License
265 stars 68 forks source link

[ENH] Use Sphinx HTML assets policy to decide whether include assets #127

Closed humitos closed 3 years ago

humitos commented 3 years ago

Sphinx v4.1.0 will include Sphinx.registry.html_assets_policy that defines the policy to whether include or not HTML assets in pages where the extension is not used.

This PR makes usage of this policy to decide if sphinx-tabs assets should be included or not in the page that's being rendered.

Reference: https://github.com/sphinx-doc/sphinx/issues/9115

welcome[bot] commented 3 years ago

Thanks for submitting your first pull request! You are awesome! :hugs:
If you haven't done so already, check out EBP's Code of Conduct and our Contributing Guide, as this will greatly help the review process.
Welcome to the EBP community! :tada:

codecov[bot] commented 3 years ago

Codecov Report

Merging #127 (33e8075) into master (d921af3) will decrease coverage by 0.32%. The diff coverage is 80.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #127      +/-   ##
==========================================
- Coverage   92.55%   92.23%   -0.33%     
==========================================
  Files           2        2              
  Lines         215      219       +4     
==========================================
+ Hits          199      202       +3     
- Misses         16       17       +1     
Flag Coverage Ξ”
pytests 92.23% <80.00%> (-0.33%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Ξ”
sphinx_tabs/tabs.py 92.16% <80.00%> (-0.33%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Ξ” = absolute <relative> (impact), ΓΈ = not affected, ? = missing data Powered by Codecov. Last update d921af3...33e8075. Read the comment docs.

foster999 commented 3 years ago

Thank @humitos, shall get the next version released including this change πŸ˜„

humitos commented 3 years ago

Thanks, @foster999 for continuing this work, and I'm sorry I wasn't able to make the latest required changes. I was on vacation πŸ˜ƒ

foster999 commented 3 years ago

No problem at all, hope you had a nice break! 😁