befeleme commented 3 years ago

Make the test work with Sphinx 4.0.x. (It was skipped when testing with 4.0.2) Fix the typo so that the regression file is actually found - it threw FileNotFoundError once the condition was corrected.

welcome[bot] commented 3 years ago

Thanks for submitting your first pull request! You are awesome! :hugs:
If you haven't done so already, check out EBP's Code of Conduct and our Contributing Guide, as this will greatly help the review process.
Welcome to the EBP community! :tada:

codecov[bot] commented 3 years ago

Codecov Report

Merging #133 (ce36c78) into master (f3cf8a9) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #133   +/-   ##
=======================================
  Coverage   92.23%   92.23%           
=======================================
  Files           2        2           
  Lines         219      219           
=======================================
  Hits          202      202           
  Misses         17       17

Flag	Coverage Δ
pytests	`92.23% <ø> (ø)`

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update f3cf8a9...ce36c78. Read the comment docs.

foster999 commented 3 years ago

Good spot, thanks for fixing this!

welcome[bot] commented 3 years ago

Congrats on your first merged pull request in this project! :tada:
Thank you for contributing, we are very proud of you! :heart:

executablebooks / sphinx-tabs

Fix test_other_with_assets_new_style w/Sphinx 4.0 #133

Codecov Report