executablebooks / sphinx-tabs

Tabbed views for Sphinx
https://sphinx-tabs.readthedocs.io
MIT License
265 stars 68 forks source link

🧪 TESTS: Add testing for Python 3.9 and pygments versions #135

Closed foster999 closed 3 years ago

foster999 commented 3 years ago

Adds tesing for:

codecov[bot] commented 3 years ago

Codecov Report

Merging #135 (86d7a1a) into master (0f185f4) will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #135   +/-   ##
=======================================
  Coverage   92.23%   92.23%           
=======================================
  Files           2        2           
  Lines         219      219           
=======================================
  Hits          202      202           
  Misses         17       17           
Flag Coverage Δ
pytests 92.23% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 0f185f4...86d7a1a. Read the comment docs.

foster999 commented 3 years ago

Hi @humitos, I've just realised that the new test using app.set_html_assets_policy("always") wasn't getting hit because our sphinx testing version was fixed below 4.1 😅

I've changed that here to test the latest between 4 and 5, and the new test is now failing. It looks like the JS asset isn't being included when the config option is set. I'm stuck on why this might be, any thoughts?

humitos commented 3 years ago

Hi @humitos, I've just realised that the new test using app.set_html_assets_policy("always") wasn't getting hit because our sphinx testing version was fixed below 4.1 sweat_smile

I remember running the test and failing locally. Then, after some debugging, I was able to fix it (see this comment https://github.com/executablebooks/sphinx-tabs/pull/127#discussion_r675979667 where we talked about this failing test)

I'm not sure how the .html/.xml files added to this PR were generated (I didn't upload them in my original PR). So, I'm guessing there is something there that may be conflicting. I'll take a look next week.

foster999 commented 3 years ago

Thanks, I'd totally forgotten about that. Working fine with a copy of the test source files now 😄

humitos commented 3 years ago

Excellent! Happy you already fixed it! 💪