executablebooks / sphinx-tabs

Tabbed views for Sphinx
https://sphinx-tabs.readthedocs.io
MIT License
264 stars 68 forks source link

Empty space at the end of tabs #139

Open jorgepiloto opened 2 years ago

jorgepiloto commented 2 years ago

Description / Summary

While using this extension, I noticed that some empty space appears at the bottom of each tab. This behavior can be seen in the latest documentation of this project :

bug_tabs

On the other hand, the README.md file does not show this empty space in the example gifs, see:

right_tab

Value / benefit

Is this an expected behavior of the tabs extension? If so, can it be disabled so the tabs look like the ones in the README.md examples?

From my point of view, this empty space is a little bit annoying, as it looks like something is missing or that a new empty line was added to the code.

Waiting for your comments on this. Thank you so much for this cool extension! 🚀

welcome[bot] commented 2 years ago

Thanks for opening your first issue here! Engagement like this is essential for open source projects! :hugs:
If you haven't done so already, check out EBP's Code of Conduct. Also, please try to follow the issue template as it helps other community members to contribute more effectively.
If your issue is a feature request, others may react to it, to raise its prominence (see Feature Voting).
Welcome to the EBP community! :tada:

foster999 commented 2 years ago

Thanks for raising this @jorgepiloto, I think had occurred in a previous version too - might be down to a change in one of the dependencies. Nonetheless, it looks like we should update our CSS to remove the extra space 😊

jorgepiloto commented 2 years ago

Thanks for pinging @foster999. If I manage to solve this locally, I will open a PR 👍🏽

foster999 commented 2 years ago

Looks like this was down to differences in the theme being used to build the examples. I'd tested with alabaster, but our docs use read-the-docs's theme. I've updated the CSS to fix this on the linked PR - please could you confirm if this works for your use case @jorgepiloto?