executablebooks / sphinx-tabs

Tabbed views for Sphinx
https://sphinx-tabs.readthedocs.io
MIT License
264 stars 68 forks source link

⬆️ UPGRADE: Bump docutils dependency to 0.17 #144

Closed foster999 closed 2 years ago

foster999 commented 2 years ago

Regression tests updated, as the new version now uses semantic section tags rather than the class of the same name.

Fixes #140

codecov[bot] commented 2 years ago

Codecov Report

Merging #144 (bcbfc5d) into master (ade8d9c) will increase coverage by 0.45%. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #144      +/-   ##
==========================================
+ Coverage   92.23%   92.69%   +0.45%     
==========================================
  Files           2        2              
  Lines         219      219              
==========================================
+ Hits          202      203       +1     
+ Misses         17       16       -1     
Flag Coverage Δ
pytests 92.69% <ø> (+0.45%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
sphinx_tabs/tabs.py 92.62% <0.00%> (+0.46%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update ade8d9c...bcbfc5d. Read the comment docs.

foster999 commented 2 years ago

@Daltz333, any thoughts on upgrading to docutils~=0.17.0?

As there doesn't seem to include any functional changes for us, we can continue to support 0.16. Should this then be something like docutils~=0.16.0,~=0.17.0?

Daltz333 commented 2 years ago

Since RTD theme added support for 0.17 and tests pass, it should be fine

return42 commented 2 years ago

@foster999 could you build a release / the current release sticks at docutils v0.16 what is a show stopper in some circumstances / thanks!

Daltz333 commented 2 years ago

I can push a release later today if he doesn't beat me to it.

return42 commented 2 years ago

I can push a release later today if he doesn't beat me to it.

Sorry for being impatient .. just to remind / Thanks!

foster999 commented 2 years ago

Sorry for being impatient .. just to remind / Thanks!

Thanks for nudging again - should be available at a pip near you!

return42 commented 2 years ago

should be available at a pip near you!

Thanks a lot .. great help for me!