executablebooks / sphinx-tabs

Tabbed views for Sphinx
https://sphinx-tabs.readthedocs.io
MIT License
264 stars 68 forks source link

Tabs not displaying correctly when title contains "``" or guilabel #155

Open filipesmg opened 2 years ago

filipesmg commented 2 years ago

Describe the bug

context When I create tabs containing in-line raw text (using double ticks as example) or :guilabel:label on the title.

expectation I expected the tabs to have no border at the bottom, consistent with other cases.

bug But instead the other tabs get an extra line at the bottom when they are selected (see attached image). Here's the code I used to create

Screenshot 2022-03-14 at 11 49 07 Screenshot 2022-03-14 at 11 54 35

Reproduce the bug

Here is an example code that I used to create the attached images.

.. tabs::

    .. tab:: ``tab1``

        test test test test test test test test 

    .. tab:: Tab2

        test test test test test test test test 

.. tabs::

    .. tab:: ``tab1``

        test test test test test test test test 

    .. tab:: Tab2

        test test test test test test test test 

.. tabs::

    .. tab:: Tab1

        test test test test test test test test 

    .. tab:: :guilabel:`Tab2`

        test test test test test test test test 

.. tabs::

    .. tab:: Tab1

        test test test test test test test test 

    .. tab:: :guilabel:`Tab2`

        test test test test test test test test 

List your environment

I'm on MacOS 12.2.1, python 3.9.5 and:

Sphinx                        4.4.0
sphinx-rtd-theme              1.0.0
sphinx-tabs                   3.2.0

But I have also tested sphinx-tabs 3.3.0.

welcome[bot] commented 2 years ago

Thanks for opening your first issue here! Engagement like this is essential for open source projects! :hugs:
If you haven't done so already, check out EBP's Code of Conduct. Also, please try to follow the issue template as it helps other community members to contribute more effectively.
If your issue is a feature request, others may react to it, to raise its prominence (see Feature Voting).
Welcome to the EBP community! :tada: