foster999 commented 2 years ago

Update setup.py dependency to allow sphinx<6. Add testing for sphinx 5, python 3.10 and pygments 2.12.0 (no functional changes since 2.10.0 for us) in Actions workflow. Remove testing for python 3.6. The package likely continues to work with this version, but we won't continue to test it. Remove testing for sphinx 2 and 4 (see next change). Update regression tests outputs to account for change in sphinx HTML output text. Oddly this seems to have been applied to sphinx 3 and 5, but not 4, making it awkward for our current regression-type tests to run against 4. Add limiting of jinja2 version due to them dropping some objects that are imported by sphinx in latest version. Update testing to use up-to-date version of pytest, to allow testing on python 3.10.

Will resolve #162

codecov[bot] commented 2 years ago

Codecov Report

Merging #164 (0d9005a) into master (0b04c8e) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #164   +/-   ##
=======================================
  Coverage   92.69%   92.69%           
=======================================
  Files           2        2           
  Lines         219      219           
=======================================
  Hits          203      203           
  Misses         16       16

Flag	Coverage Δ
pytests	`92.69% <ø> (ø)`

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update c024ea8...0d9005a. Read the comment docs.

foster999 commented 2 years ago

Hey @Daltz333, do you think the changes to the testing coverage here seem reasonable?

Daltz333 commented 2 years ago

Yeah this looks good!

executablebooks / sphinx-tabs

👌 IMPROVE: Add support and testing for sphinx 5 #164

Codecov Report