executablebooks / sphinx-tabs

Tabbed views for Sphinx
https://sphinx-tabs.readthedocs.io
MIT License
263 stars 67 forks source link

Remove no longer needed declare_namespace() #177

Closed kloczek closed 1 year ago

kloczek commented 1 year ago

This fix removes declare_namespace() which is no longer needed. it used old style namespaces which has been using pkg_resources module which is part of the setuptools and which is as well depreceted now.

welcome[bot] commented 1 year ago

Thanks for submitting your first pull request! You are awesome! :hugs:
If you haven't done so already, check out EBP's Code of Conduct and our Contributing Guide, as this will greatly help the review process.
Welcome to the EBP community! :tada:

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage has no change and project coverage change: -0.02 :warning:

Comparison is base (9431223) 97.27% compared to head (034d5f8) 97.26%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #177 +/- ## ========================================== - Coverage 97.27% 97.26% -0.02% ========================================== Files 2 2 Lines 220 219 -1 ========================================== - Hits 214 213 -1 Misses 6 6 ``` | Flag | Coverage Δ | | |---|---|---| | pytests | `97.26% <ø> (-0.02%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=executablebooks#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://app.codecov.io/gh/executablebooks/sphinx-tabs/pull/177?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=executablebooks) | Coverage Δ | | |---|---|---| | [sphinx\_tabs/\_\_init\_\_.py](https://app.codecov.io/gh/executablebooks/sphinx-tabs/pull/177?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=executablebooks#diff-c3BoaW54X3RhYnMvX19pbml0X18ucHk=) | `100.00% <ø> (ø)` | |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

foster999 commented 1 year ago

Thanks, I hadn't come across this before and wasn't aware that it was redundant. Tests are all passing 👍🏻

welcome[bot] commented 1 year ago

Congrats on your first merged pull request in this project! :tada: congrats
Thank you for contributing, we are very proud of you! :heart:

kloczek commented 1 year ago

Thank you 👍 😄