Closed mitya57 closed 10 months ago
Thanks for submitting your first pull request! You are awesome! :hugs:
If you haven't done so already, check out EBP's Code of Conduct and our Contributing Guide, as this will greatly help the review process.
Welcome to the EBP community! :tada:
Thanks for raising the PR ☺️ we've had previous requests for supporting translation, so I wanted to check whether this change will prevent this in future? We would generally try to support new sphinx features rather than disable them
I disabled this feature only in tests, it won't be disabled for sphinx-tabs users.
When you decide to drop support for old Sphinx versions (< 7.1), you can revert this change and update the test expectations instead.
I think it would be best for the tests to reflect the latest sphinx version. We should be able to fix this by regenerating the regression tests under a normal test run
But then the tests will fail with older Sphinx.
Although, I can put some .replace()
in Python code to make it work with old Sphinx too. Will that work for you?
I have implemented the approach from my last comment now.
Congrats on your first merged pull request in this project! :tada:
Thank you for contributing, we are very proud of you! :heart:
The tests were failing with this diff:
See https://bugs.debian.org/1042589 for the full log.
This was caused by sphinx-doc/sphinx#11509, which is part of Sphinx ≥ 7.1.0.