search

executablebooks / sphinx-tabs

Tabbed views for Sphinx
https://sphinx-tabs.readthedocs.io
MIT License
263 stars 67 forks source link

Fix tests for Sphinx 7.2 #179

Closed MeggyCal closed 9 months ago

MeggyCal commented 10 months ago

Sphinx changed “Permalink” to “Link” in https://github.com/sphinx-doc/sphinx/issues/10049.

I will try to make it backwards-compatible in the next commit.

welcome[bot] commented 10 months ago

Thanks for submitting your first pull request! You are awesome! :hugs:
If you haven't done so already, check out EBP's Code of Conduct and our Contributing Guide, as this will greatly help the review process.
Welcome to the EBP community! :tada:

foster999 commented 9 months ago

The updated regression outputs are working, but the test fixture change isn't working for Python 3.7 and 3.8 which use older versions of sphinx. Your change is in the doctree regression, but I think the change is actually in the HTML.

If you want to try to address this look into using beautifulsoup to remove the title attribute from those elements in the HTML (regardless of sphinx version). This would allow us to ignore any other changes to that text in future too

codecov[bot] commented 9 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

:loudspeaker: Thoughts on this report? Let us know!.

foster999 commented 9 months ago

Decided that we should stop testing earlier versions of sphinx (and therefore Python), so we don't have to keep updating tests for non-functional changes to sphinx and its dependencies.

welcome[bot] commented 9 months ago

Congrats on your first merged pull request in this project! :tada: congrats
Thank you for contributing, we are very proud of you! :heart: