Open christophfroehlich opened 6 months ago
Thanks for opening your first issue here! Engagement like this is essential for open source projects! :hugs:
If you haven't done so already, check out EBP's Code of Conduct. Also, please try to follow the issue template as it helps other community members to contribute more effectively.
If your issue is a feature request, others may react to it, to raise its prominence (see Feature Voting).
Welcome to the EBP community! :tada:
Thanks for raising the issue. I'm afraid I don't understand jQuery well enough to work out what's wrong here - I remember these lines being necessary for our js to work with both commonJS and jQuery, but I don't know how they would need to be changed to avoid the errors here
Describe the bug
When I add a table with DataTables/jQuery scripts inside a tab, then the javascript is broken.
Uncommenting these few lines make all work again https://github.com/executablebooks/sphinx-tabs/blob/0632f4bfb4df799c4c66612051ce5f1aabf9269b/sphinx_tabs/static/tabs.js#L137-L145
Reproduce the bug
Add a table from the examples into a tab
test_table.zip
List your environment
sphinx-copybutton 0.5.2 sphinx-multiversion 0.2.4 sphinx-rtd-theme 2.0.0 sphinx-tabs 3.4.1 sphinxcontrib-applehelp 1.0.7 sphinxcontrib-devhelp 1.0.5 sphinxcontrib-htmlhelp 2.0.4 sphinxcontrib-jquery 4.1 sphinxcontrib-jsmath 1.0.1 sphinxcontrib-qthelp 1.0.6 sphinxcontrib-serializinghtml 1.1.9