search

executablebooks / sphinx-tabs

Tabbed views for Sphinx
https://sphinx-tabs.readthedocs.io
MIT License
263 stars 67 forks source link

Using body[data-theme] instead of html[data-theme] breaks using theme switcher #194

Open AliveDevil opened 1 month ago

AliveDevil commented 1 month ago

Describe the bug

A theme switcher component sets data-theme on html-element, not on html.body, as html attributes aren't inherited, Tabs break when using html.data-theme.

image

Reproduce the bug

  1. Create project with sphinx-rtd, sphinx-tabs and sphinx-rtd-dark-mode
  2. Create tab
  3. Switch theme

List your environment

No response

welcome[bot] commented 1 month ago

Thanks for opening your first issue here! Engagement like this is essential for open source projects! :hugs:
If you haven't done so already, check out EBP's Code of Conduct. Also, please try to follow the issue template as it helps other community members to contribute more effectively.
If your issue is a feature request, others may react to it, to raise its prominence (see Feature Voting).
Welcome to the EBP community! :tada: