search

executablebooks / sphinx-tabs

Tabbed views for Sphinx
https://sphinx-tabs.readthedocs.io
MIT License
264 stars 68 forks source link

2.0.0 version breaks pdf generation #99

Closed nicozanf closed 3 years ago

nicozanf commented 3 years ago

I cannot anymore obtain any pdf output.

Even with the simple "Apple & Pear" example, that still works fine with 1.3.0, I always get the following error from rinohtype:

rinoh.frontend.sphinx (0.4.2) from /home/nico/.local/lib/python3.8/site-packages/rinoh/frontend/sphinx/init.py Traceback (most recent call last): File "/home/nico/.local/lib/python3.8/site-packages/rinoh/frontend/init.py", line 27, in map_node return cls._mapping[nodename.replace('-', '')](node, **context) KeyError: 'div'

The simple workaround that I've found is to downgrade to sphinx-tabs 1.3.0.

Ubuntu 20.10 Sphinx version: 3.2.1 Python version: 3.8.6 (CPython) Docutils version: 0.16 release Jinja2 version: 2.11.2

welcome[bot] commented 3 years ago

Thanks for opening your first issue here! Engagement like this is essential for open source projects! :hugs:
If you haven't done so already, check out EBP's Code of Conduct. Also, please try to follow the issue template as it helps other community members to contribute more effectively.
If your issue is a feature request, others may react to it, to raise its prominence (see Feature Voting).
Welcome to the EBP community! :tada:

foster999 commented 3 years ago

Thanks @nicozanf. I'm not familiar with rinohtype, please could you let me know what command you're using to build the basic example?

This would be a good opportunity to get some tests implemented for pdf builds too.

nicozanf commented 3 years ago

Thank you!

I was trying to reproduce the problem with the simplest possible example, but I've found that this works fine on both versions ;-(

Sorry, I need more time to check exactly what's wrong. And I'll surely post the simplest possible example, in order to let you implement them for pdf builds test.

Nico

Daltz333 commented 3 years ago

I cannot reproduce this. PDF builds fine for me

nicozanf commented 3 years ago

I've been able to reproduce the bug, even with the simple test_pdf example that I'm attaching here test_pdf.zip. You will need to 'pip install rinohtype' before using it. See the enclosed readme.txt for simple instructions.

NB: after a succesfull run you must delete the hidden folder

temp/.doctrees

(where temp is the building folder in my example) otherwise it will be reused and you will never get an error anymore!