🐛 FIX: Remove not imported top-level package docutils

executablebooks / sphinx-thebe

A Sphinx extension to convert static code into interactive code cells with Jupyter, Thebe, and Binder.

https://sphinx-thebe.readthedocs.io/en/latest/

MIT License

28 stars 15 forks source link

🐛 FIX: Remove not imported top-level package docutils #21

Closed deeplook closed 3 years ago

deeplook commented 3 years ago

This should help fix build issues on https://readthedocs.io like:

Exception occurred:
  File "/home/docs/checkouts/readthedocs.org/user_builds/xyz-spaces-python/envs/latest/lib/python3.7/site-packages/sphinx_thebe/__init__.py", line 182, in skip
    raise docutils.nodes.SkipNode
NameError: name 'docutils' is not defined

Plus applied some isort-like manual grouping of imports.

welcome[bot] commented 3 years ago

Thanks for submitting your first pull request! You are awesome! :hugs:
If you haven't done so already, check out EBP's Code of Conduct and our Contributing Guide, as this will greatly help the review process.
Welcome to the EBP community! :tada:

choldgraf commented 3 years ago

oi - good catch @deeplook , I was trying to figure out what the heck was going on there!

welcome[bot] commented 3 years ago

Congrats on your first merged pull request in this project! :tada:
Thank you for contributing, we are very proud of you! :heart: