search

executablebooks / sphinx-thebe

A Sphinx extension to convert static code into interactive code cells with Jupyter, Thebe, and Binder.
https://sphinx-thebe.readthedocs.io/en/latest/
MIT License
28 stars 15 forks source link

Make it possible to configure line numbers via CodeMirror #38

Open patrickmineault opened 3 years ago

patrickmineault commented 3 years ago

Description / Summary

CodeMirror supports showing line numbers through the lineNumbers option. This option appears to be set to false by default. It would be nice if we could enable this option from this Sphinx theme.

Value / benefit

When the code is run in a cell and it has an error, it references line numbers. It would be nice if those line numbers were visible in the editor.

Implementation details

I think this option could be forwarded from sphinx-thebe to mainland thebe, and then onwards to CodeMirror.

Tasks to complete

welcome[bot] commented 3 years ago

Thanks for opening your first issue here! Engagement like this is essential for open source projects! :hugs:
If you haven't done so already, check out EBP's Code of Conduct. Also, please try to follow the issue template as it helps other community members to contribute more effectively.
If your issue is a feature request, others may react to it, to raise its prominence (see Feature Voting).
Welcome to the EBP community! :tada:

choldgraf commented 3 years ago

Hey - yep, this would indeed be useful. I think that it could be resolved by #17 (and one shot at implementing this here #25).