Closed mmcky closed 1 year ago
Thanks for submitting your first pull request! You are awesome! :hugs:
If you haven't done so already, check out EBP's Code of Conduct and our Contributing Guide, as this will greatly help the review process.
Welcome to the EBP community! :tada:
sphinx-book-theme
which is currently set to sphinx<5
so it is currently testing sphinx==4.5
. This PR has been tested on sphinx5
Happy to review a PR over in the book theme to bump it up to Sphinx 5 compatibility. I believe it already supports Sphinx > 4: https://github.com/pydata/pydata-sphinx-theme/blob/3ac01cf378b4f58f8c4c411a82fb85324c909ef0/pyproject.toml#L22-L28
maybe @AakashGfude can wrap this into the cruft-removing PR that he is taking over
sphinx-book-theme
before finalisingOK we now have the latest version of the book theme in pre-release:
I've updated setup.py
to install the pre-release from the docs, and went ahead and bumped to Sphinx 6 support as well. I'm starting to feel more that we should just drop the upper bound of Sphinx, it is really tedious to have to keep bumping versions across all of these repositories. But that's a conversation for another day.
I think we should merge this and make a release if the tests pass and the docs look good. They look normal to me so I'm gonna merge.
Congrats on your first merged pull request in this project! :tada:
Thank you for contributing, we are very proud of you! :heart:
This PR updates the testing infrastructure to test against
sphinx4
andsphinx5
andsphinx6
(droppingsphinx3
).It also replaces
sphinx-panels
withsphinx-design
assphinx-panels
is now deprecated.