search

executors / futures

A proposal for a futures programming model for ISO C++
22 stars 7 forks source link

definition of std::this_thread::future_get refers to std::decay_t<Future>::value_type #103

Closed RedBeard0531 closed 6 years ago

RedBeard0531 commented 6 years ago

But the concept doesn't require ::value_type. Should future_get use future_value_t or should we add SF<T>::value_type to the concept. I personally think both would be best for consistency with other types that provide ::value_type, but it seemed like the consensus in #31 went the other way. I'd be happy to make the wording change if you tell me which way you want it to go.

LeeHowes commented 6 years ago

Please change to use future_value_t.

I would like value_type too but as you point out we agreed to focus on the trait style.

dhollman commented 6 years ago

@LeeHowes Should the same apply to the Promise concept?

LeeHowes commented 6 years ago

I suppose so... let's be consistent. This is LEWG territory really I think.

dhollman commented 6 years ago

Fixing this now, btw.

dhollman commented 6 years ago

should be fixed; this can be closed with #106 is accepted.

LeeHowes commented 6 years ago

Closing.