executors / futures

A proposal for a futures programming model for ISO C++
22 stars 7 forks source link

Use of `promise_contract_t<T>::static_query_v<E> == true` is invalid #94

Open chriskohlhoff opened 6 years ago

chriskohlhoff commented 6 years ago

promise_contract_t<T>::static_query_v<E> == true is invalid since promise_contract_t doesn't support static_query_v (i.e. a compile-time constant expression query). Was it supposed to be can_query_v<E, promise_contract_t<T>>?

dhollman commented 6 years ago

@LeeHowes @brycelelbach I can make this change.

LeeHowes commented 6 years ago

Go ahead.

dhollman commented 6 years ago

A couple of problems:

brycelelbach commented 6 years ago

Is this fixed?

dhollman commented 6 years ago

Mostly. static_query_v is still there for cancellable_promise_contract. The part in the SemiFuture requirements table also still needs to be fixed. I'll put in a pull request later this week.