Closed vadorovsky closed 2 months ago
Seems good to me.
I would like to make one final consideration: looking at the history the commit fix: Handle offsets and their bounds in buffer_append_str didn't solve the verifier issue, but it was solved in the next commit fix: Use container_id_buffer also for parent_buf. so is it possible to revert to the previous function signature of the function buffer_append_str
? I'm ok if it's the only way to solve the verifier issue, I'm only asking if we can keep the signature less weird
@banditopazzo There were two separate verifier issues which both of these commits were solving. :sweat_smile:
fixed the verifier error on kernel 5.13 fixed an another verifier error on kernel 6.0
if you check out to a change before both of commits, integration tests fail for both 5.13 and 6.0. I initially didn't notice the latter, but that's the case.
If you check out to the first commit, the tests for 6.0 will fail.
And I think that both changes make sense (regardless of verifier errors) - the first one makes the offset checks more reliable in the whole helper, the second one uses your buffer struct consequently. :)
The format of cgroup path is different for systemd and cgroupfs drivers.
For systemd driver, it's
For cgroupfs driver, it's
Handle both formats.