obs-websocket vendor requests issues

[Moulaythami]

Hi @exeldro,

First of all thank you so much for all the hard work and dedication making all the plugins you did. They are all gems in the OBS Studio landscape and we owe you a lot making our work easier. (Espacialy with source dock, monitor audio, downstream keyer)

I'm using OBS with Bitfocus Companion for having a streamdeck emulator in a Custom Browser Docks. It looks like this:

I've tested almost all the vendor request listed here: https://obsproject.com/forum/resources/downstream-keyer.1254/updates#resource-update-5109

here some of the request that have an issue for me on Bitfocus Companion:

1. dsk_remove_scene

{
   "vendorName": "downstream-keyer",
   "requestType": "dsk_remove_scene",
   "requestData": {
    "dsk_name": "MX1",
    "scene": "MX1" // (⚠️ I don't why but this whole dsk_remove_scene vendor request doesn't work)
  }
}

2. dsk_set_transition

   {
   "vendorName": "downstream-keyer",
   "requestType": "dsk_set_transition",
   "requestData": {
   "dsk_name": "MX1",
   "transition": "fade", // (⚠️ "fade" "cut" Doesn't work, I don't know what should I write)
   "transition_type": "match", // (✅ Works also with "show" and "hide")
   "transition_duration": 1000 // (✅ Works)
   }
   }

3. dsk_scene_changed

   {
   "vendorName": "downstream-keyer",
   "requestType": "dsk_scene_changed",
   "requestData": {
   "dsk_name": "MX1",
   "new_scene": "MX2",
   "old_scene": "MX1"(⚠️ I don't why but this whole dsk_scene_changed vendor request doesn't work)
   }
   }

I'm sure that you have better to do. Thank you in the name of the silent majority that love your work, Moulaythami

[exeldro]

1 is a bug that I will fix 2 Use the name of the transition in the language of your obs, for English "Fade" and "Cut" 3 dsk_scene_changed is not a vendor request, it is a vendor event that is send

[Moulaythami]

1 is a bug that I will fix 2 Use the name of the transition in the language of your obs, for English "Fade" and "Cut" 3 dsk_scene_changed is not a vendor request, it is a vendor event that is send

1 Thank you. Awesome you already fixed that. 👏 2 It works. ✅ I changed my obs language and in english, switched my computer in english (macOS) and "match" "show" "hide" works with "fade" "cut" 3 Don't know how to do. 😥 I tried in Bitfocus Companion to make a button a vendor event but don't have the knowledge yet to succed. I think we can close the issue since it's a Bitfocus Companion GUI issue, since the code is working.

Thank you a lot. I wish you the best