Closed statik closed 3 years ago
I will rebase this to pull in the build fixes.
I have no Mac to verify this PR. Can you verify the CI artifact works correct?
@exeldro confirmed! Works great here.
sudo rm -rf '/Library/Application Support/obs-studio/plugins/media-controls/'
otool -l '/Library/Application Support/obs-studio/plugins/media-controls/bin/media-controls.so'| grep Qt
name @executable_path/../Frameworks/QtWidgets.framework/Versions/5/QtWidgets (offset 24)
name @executable_path/../Frameworks/QtGui.framework/Versions/5/QtGui (offset 24)
name @executable_path/../Frameworks/QtCore.framework/Versions/5/QtCore (offset 24)
Thank you 🤝
Thank you for creating this plugin 👍
When I tried to use it today after installing from media-controls-0.3.0-macos.pkg.zip, I noticed this load failure in my OBS logs:
I believe this is likely the underlying problem with #15. When I inspected the library paths with otool, I saw paths for the Qt dependencies were still pointing to the tmp location used during the build:
I see that the CI build script is already invoking
install_name_tool
to fix up these paths after the build and before packaging, it seems the path just didn't match the dependency path used earlier in the build. I created this temporary script to test the change to the paths, and after running this script against my local install, the plugin loads correctly and works great!I hope this PR is helpful and will make it easy to cut a new release that works on macOS. Let me know if you would like me to test the new release or do anything else to help.