exeldro / obs-move-transition

Move transition for OBS Studio
https://obsproject.com/forum/resources/move-transition.913/
GNU General Public License v2.0
670 stars 48 forks source link

【Issue Report】UI is blocked since of reversed order for requesting lock #174

Closed walker-WSH closed 1 year ago

walker-WSH commented 1 year ago

Hi @exeldro , I detected an UI block issue which is caused by obs-move-transition.dll. Here is my analysis result:

As current logic in obs, scene->video_mutex should be requested after obs->data.sources_mutex. If there exist reversed order, the block issue will happen.

It seems you should not invoke obs_scene_create_private between lock(scene->video_mutex) and unlock(lock(scene->video_mutex))

Please confirm. Thanks~


l_141445122_1767_ada04107b7e09aae63c5c38374a6d67d

exeldro commented 1 year ago

this should be fixed by https://github.com/exeldro/obs-move-transition/commit/752c06b10f7f4dcd5fe184465490abb336ce178f