search

exeldro / obs-move-transition

Move transition for OBS Studio
https://obsproject.com/forum/resources/move-transition.913/
GNU General Public License v2.0
630 stars 45 forks source link

Scale to Outer Bounds Issue with Crop to Bounding Box when Move Transition with Zoom & Fade #214

Closed chrisspiegl closed 2 weeks ago

chrisspiegl commented 1 month ago

I've started to use the Move Transitions and found that when I use the "Scale to Outer Bounds", Bounding Box Alignment set to "Center" and "Crop to Bounds" on elements, and then transition between scenes, the crop appears to be flickering / snapping on and off during the transition. This makes the transition unusable and eratic.

I tried using "Stretch to Bounds", "Scale to Inner Bounds" and the same thing does not happen.

I tried a number of different other things (Scale to Outer Bounds with different Bounding Box Positioning). But there are many that appear to transition without the grop, and then at the end of the transition, the crop is applied.

Is this expected behavior or a bug? Is there a way to fix it and still use "Scale to Outer Bounds"?

Best, Chris

chrisspiegl commented 1 month ago

I looked into the code and found that the "Crop to Outer Bounds" appears to only be active if the difference in cop is "significant enough"? Maybe that's the issue here? Shouldn't it be respected no matter how small the crop is?

https://github.com/exeldro/obs-move-transition/blob/04eb2b62d69f71fbc0d98519f243e2225c61b133/move-transition.c#L407-L410

exeldro commented 3 weeks ago

I was able to replicate the issue and made a fix for it. You can download a test version from the bottom of this page: https://github.com/exeldro/obs-move-transition/actions/runs/9466205336

chrisspiegl commented 2 weeks ago

I tested v3.0.1 and the build, and they appear to be working. However, my scenes also changed significantly in the meantime. 🙈 In case this issue comes back, I'll let you know.