search

exeldro / obs-replay-source

Replay source for OBS studio
GNU General Public License v2.0
143 stars 20 forks source link

Adds frame seeking hotkeys #55

Closed DavidXenakis closed 9 months ago

DavidXenakis commented 10 months ago

Also, refactor the method for finding the right timestamp to start/end at when a trim exists. The new method uses a binary search, so it should be more efficient than a linear seek. I use this method to wrap around in the frame seeking.

Tested using trimmed videos at different speeds, and everything works as expected.

Updated Readme with new hotkeys

DavidXenakis commented 10 months ago

@exeldro Could you please take a look? This is a killer feature for my use-case!

exeldro commented 10 months ago

At first glance it looks good. I plan on taking a good look this week.

DavidXenakis commented 9 months ago

With my latest changes, I've addressed your comments, added localization text, and added a feature to allow a coarse grained frame step, which defaults to 5 frames. This allows me to, for instance, hold shift when stepping frames to step a larger amount.

exeldro commented 9 months ago

I will do some fixes on master