search

exeldro / obs-shaderfilter

OBS Studio filter for applying an arbitrary shader to a source.
GNU General Public License v2.0
377 stars 39 forks source link

Off-scene transition video sources don't update or become visible for rendering when used #41

Closed FishOfTheNorthStar closed 6 months ago

FishOfTheNorthStar commented 6 months ago

When I would try to use video media sources as textures, I found they'd only work for me if they were in the current scene and visible. For transitions this was a problem since I'd need many copies of sources, also the videos should restart with the transition restarts.

I hacked a little fix in here locally that seems to be working for me.

I'm struggling my way through github's learning curve. Apologies if I'm making a mess of things. Link below is to a commit that, for me, corrects the issue outlined.

FishOfTheNorthStar commented 6 months ago

I have tried to fork this project, edit my changes in, and commit them. Here is a link to that. https://github.com/FishOfTheNorthStar/obs-shaderfilter/commit/849350099ce5f7ae8abc7e05123e50908aa7e8f4

If I could be notified when this fork is no longer needed for anything, that would be great so I can delete it and not confuse people looking for the proper project home. It seems like there's a way to automate that but I'm so new to github, I'm worried about anything that says it automatically deletes stuff. So if you could drop a note or something on here to the effect of 'we no longer need that repo' when you're ready, that'd be great, thanks.

exeldro commented 6 months ago

This looks like an issue that needs to be fixed, but I would do it an other way than you did it and also fix it for not transition shaders. I will link my solution to the issue here when I made it.

exeldro commented 6 months ago

I made a fix, you can see the changes here and you can download a test build from the bottom of this page. Let me know if it fixes everything for you.

FishOfTheNorthStar commented 6 months ago

Thank you, I've tested your fix here locally and it's working great for what I'm doing. I'm going to remove that temporary repo I forked now. This issue is fully resolved for me.