exeldro / obs-source-profiler

GNU General Public License v2.0
37 stars 1 forks source link

CPU values of stacked filters look wrong #7

Open xurei opened 4 hours ago

xurei commented 4 hours ago

Consider this setup: A simple scene with a source and two Effect filters:

The Profiler looks like this: image

It gets even worse when you stack more filters: image

This gives the wrong impression that all filters takes a lot of CPU, where only the first one is actually CPU-intensive. The source has a very high CPU usage, but the scene itself uses less CPU time, which does not make sense.

I see two options to fix this:

  1. show the CPU usage of the filters MINUS the CPU usage of the filters above it, - or -
  2. only add the CPU usage of the last filter to the CPU usage of the source, and maybe show the filters in a waterfall view (but this might quickly become unreadable for sources with many filters)

I think solution 1 is better: it is less confusing than solution 2 and is consistent with how sources are displayed in a scene, i. e. by showing the "Self CPU usage" of each child item, and adding them as the total CPU time of the parent element.

exeldro commented 1 hour ago

I agree solution 1 sounds like the better one.