rse
commented
3 years ago Ok, I can confirm that with the audio_output_stop() in source_record_filter_destroy most of the crashes are gone. Unfortunately, when I open/close OBS Studio and switch between scene collections long enough I still get the following types of crashes (this time Source Record is part of the strack trace):
Unhandled exception: c0000005
Date/Time: 2021-06-20, 01:19:58
Fault address: 7FFA7E59AC8F (c:\users\rse\prj\obs-studio-msg-filmstudio\dst\bin\64bit\obs.dll)
libobs version: 27.0.1 (64-bit)
Windows version: 10.0 build 19043 (release: 2009; revision: 1052; 64-bit)
CPU: Intel(R) Core(TM) i5-10600K CPU @ 4.10GHz
Thread 16BDC: audio-io: audio thread (Crashed)
Stack EIP Arg0 Arg1 Arg2 Arg3 Address
0000000EFBC9F270 00007FFA7E59AC8F 00007FFACBAF6620 0000000EFBC9F8B0 0000000000000048 00007FFACB9D1374 obs.dll!obs_filter_get_parent+0x2f
0000000EFBC9F2A0 00007FFAAFAA267D 0002276C5AF4E954 0002276C59D4FB2C 000000000006E400 0002276A2A323954 source-record.dll!calc_min_ts+0xd
0000000EFBC9F500 00007FFA7E57E5B5 00000583A4BD0283 0000000000000015 000000000006E000 0002276C5AF4E954 obs.dll!input_and_output+0x225
0000000EFBC9F780 00007FFA7E57E169 0000000000000015 00000180530DFE40 0000000000000000 0000000000000000 obs.dll!audio_thread+0xf9
0000000EFBC9F7D0 00007FFAB0AF5924 000001804B8725C0 0000000000000000 0000000000000000 0000000000000000 w32-pthreads.dll!ptw32_threadStart+0x74
0000000EFBC9F850 00007FFAC9941BB2 0000000000000000 0000000000000000 0000000000000000 0000000000000000 ucrtbase.dll!0x7ffac9941bb2
0000000EFBC9F880 00007FFACB4F7034 0000000000000000 0000000000000000 0000000000000000 0000000000000000 kernel32.dll!0x7ffacb4f7034
0000000EFBC9F8B0 00007FFACBA02651 0000000000000000 0000000000000000 0000000000000000 0000000000000000 ntdll.dll!0x7ffacba02651How to avoid these second types of crashes I've still not figured out. But at least we now already know that the following updated patch fixes most of the problems:
exeldro
naveenkcherukuri
KeiBoogie
I'm experiencing crashes of OBS Studio on shutdown and when a scene collection is changed. Unfortunately, it is not really deterministic, but the crashes most of the time look like this:
With lots of testing, I figured out that although Source Record is NEVER part of those stack traces, it actually IS(!) the root cause of them. And because the crashes always looks very similar but not exactly identical, it seems like a strange timing problem. As I'm not an OBS Studio developer and do not know the internals well enough, I've applied a basic device & conquer approach and found the root cause in the two lines of Source Records
source_record_filter_destroyfunction:If I comment out those two lines, the crashed fully stop. Once they are part of the game, about every 3-4th try, OBS Studio crashes at shutdown. Although I've no deterministic scenario at hand, I'm rather sure that these two lines are the root cause. Logically they look correct, of course. But they seem to badly interact with OBS Studio's other scene/source shutdown procedures and rather reliable cause the crashes. By comparing your other audio shutdown steps, I've now figure out that performing a
audio_output_stop(context->audio_output)just beforeaudio_output_close(context->audio_output)nearly solves the problem. OBS Studio then at least crashes far fewer times on shutdown, but still nearly every time on scene collection switch. So, it helps and it seems to be a good additional step to do, but unfortunately it still doesn't really resolve the entire problem.This is the patch I would at least recommend to reduce the problems:
bugfix.diff.txt
And for completeness reasons I append my particular OBS Studio profile and scene collection I use for testing:
config.zip
PS: When the two mentioned lines are commented out, the crashes stop immediately. But, interesting, as your Virtual Cam Filter is also part of my setup, I then get a nearly identical problem there. There the crash dumps at least show the Virtual Cam Filter's influence (see below). So, I guess the same destroy trouble exists there, too.