exelix11 / SysDVR

Stream switch games to your PC via USB or network
GNU General Public License v2.0
1.52k stars 88 forks source link

[Bug] frame_size error when USB streaming to file #228

Closed nbubash closed 1 year ago

nbubash commented 1 year ago

Describe the bug USB stream to file save produces error:

Starting stream, press return to stop. [mp2 @ 000001eeb8e5a0c0] frame_size (1152) was not respected for a non-last frame Terminating ReceiveFromDeviceThread for Both due to System.Exception: Assertion failed: -22 Unknown error at SysDVR.Client.Player.Exten.Assert(Int32 code, Func`1 MessageFun) at SysDVR.Client.FileOutput.Mp4AudioTarget.SendFrame(AVFrame* frame) at SysDVR.Client.FileOutput.Mp4AudioTarget.SendData(Byte[] data, Int32 size, UInt64 ts) at SysDVR.Client.FileOutput.Mp4AudioTarget.SendData(PoolBuffer block, UInt64 ts) at SysDVR.Client.MultiStreamThread.DataReceived(PacketHeader& header, PoolBuffer body) at SysDVR.Client.StreamThread.DeviceThreadMain(CancellationToken token)

To Reproduce Trying to stream video/audio through USB to a file. Stream to video player and rtsp work fine. I am using the dvr patch.

Expected behavior Save to file.

Setup information

Additional context I have tried different computers and cables.

exelix11 commented 1 year ago

This is not a feature i test much and yes i can confirm this issue. While trying to fix it i noticed that the produced file has audio and video out of sync of about one second, was this the case for previous versions as well ?

exelix11 commented 1 year ago

I believe this build should fix the issue, if you confirm i'll go ahead and update the current release

nbubash commented 1 year ago

I hadn't tried any previous versions, 5.5.5 is the only one I've used but that build does work now and the audio seems to be synced correctly.

exelix11 commented 1 year ago

I updated the current release with a fix for this, anyone else who is affected just needs to download the client again